Update examples in README #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous output had a trailing backslash on the last hash line; while this is apparently valid for both pip-sync and pip install, IMHO it looks like a bug, and it also doesn’t reflect what pip-compile currently emits (as of version 6.12.3), so update the example. This puts the hashes example out of sync with some of the other examples in the README, but they weren’t all in sync before either (various examples were already referencing Django 4, 3 or 2), so I hope that’s not an issue.
webknjaz
approved these changes
Apr 1, 2023
|
I’m not sure what to make of the CI failure, is it something that can randomly happen? |
atugushev
reviewed
Apr 1, 2023
In one case (layered requirements), I had to add a constraint on the django-debug-toolbar version because otherwise no solution was found by the legacy resolver. (The backtracking resolver does find a solution, but isn’t the default yet.) This should probably be revisited later, ideally by someone more knowledgeable than me :)
auto-merge was automatically disabled
April 2, 2023 00:08
Head branch was pushed to by a user without write access
|
Alright, I added a second commit updating the other |
atugushev
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous output had a trailing backslash on the last hash line; while this is apparently valid for both pip-sync and pip install, IMHO it looks like a bug, and it also doesn’t reflect what pip-compile currently emits (as of version 6.12.3), so update the example.
This puts the hashes example out of sync with some of the other examples in the README, but they weren’t all in sync before either (various examples were already referencing Django 4, 3 or 2), so I hope that’s not an issue.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.