Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --cache-dir to --pip-args for backtracking resolver #1827

Merged
merged 4 commits into from Apr 4, 2023
Merged

Pass --cache-dir to --pip-args for backtracking resolver #1827

merged 4 commits into from Apr 4, 2023

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Mar 23, 2023 •
edited by atugushev

Closes #1795

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@q0w
Copy link
Contributor Author

q0w commented Mar 23, 2023

note: install_options is removed pypa/pip@a04748d

atugushev
atugushev approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev added the bug Something is not working label Mar 26, 2023
@atugushev atugushev changed the title Pass cache_dir to pip_args for backtracking resolver Pass —cache-dir to —pip-args for backtracking resolver Mar 26, 2023
@atugushev atugushev changed the title Pass —cache-dir to —pip-args for backtracking resolver Pass --cache-dir to --pip-args for backtracking resolver Mar 26, 2023
@atugushev atugushev enabled auto-merge (squash) March 27, 2023 16:53
@atugushev atugushev disabled auto-merge March 28, 2023 16:21
@atugushev atugushev enabled auto-merge (squash) March 28, 2023 16:22
@atugushev atugushev disabled auto-merge March 28, 2023 16:22
@atugushev atugushev enabled auto-merge (squash) April 4, 2023 15:29
@atugushev atugushev merged commit d931833 into jazzband:main Apr 4, 2023
39 of 40 checks passed
@q0w q0w deleted the cache-dir branch April 4, 2023 16:22
@atugushev atugushev added this to the 6.13.0 milestone Apr 6, 2023
@burnes burnes mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

"--cache-dir" flag is ignored when specifying "--resolver=backtracking"
2 participants
@q0w @atugushev