Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text of resolver warning #1776

Merged
merged 2 commits into from Dec 14, 2022
Merged

Improve text of resolver warning #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f35a4
Improve text of resolver warning
StevenMaude Dec 14, 2022
86c7315
Correct resolver warning in test
StevenMaude Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions piptools/scripts/compile.py
View file
Open in desktop
Expand Up @@ -383,9 +383,10 @@ def cli(

if resolver_name == "legacy":
log.warning(
"WARNING: using legacy resolver is deprecated and will be removed in "
"future versions. The default resolver will be change to 'backtracking' "
"in 7.0.0 version. Specify --resolver=backtracking to silence this warning."
"WARNING: the legacy dependency resolver is deprecated and will be removed"
atugushev marked this conversation as resolved.
Show resolved Hide resolved
" in future versions of pip-tools. The default resolver will be changed to"
" 'backtracking' in pip-tools 7.0.0. Specify --resolver=backtracking to"
" silence this warning."
)

###
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cli_compile.py
View file
Open in desktop
Expand Up @@ -2736,7 +2736,7 @@ def test_print_deprecation_warning_if_using_legacy_resolver(runner, current_reso
out = runner.invoke(cli)
assert out.exit_code == 0, out

expected_warning = "WARNING: using legacy resolver is deprecated"
expected_warning = "WARNING: the legacy dependency resolver is deprecated"
if current_resolver == "legacy":
assert expected_warning in out.stderr
else:
Expand Down