Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt PEP-621 for packaging #1763

Merged
merged 2 commits into from Dec 11, 2022
Merged

Adopt PEP-621 for packaging #1763

merged 2 commits into from Dec 11, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Dec 11, 2022

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@ssbarnea ssbarnea added the bug Something is not working label Dec 11, 2022
@ssbarnea ssbarnea added this to the 6.12.0 milestone Dec 11, 2022
@ssbarnea ssbarnea force-pushed the fix/pep-621 branch 4 times, most recently from da67b45 to 6b77f22 Compare December 11, 2022 10:42
@ssbarnea ssbarnea marked this pull request as ready for review December 11, 2022 12:37
@ssbarnea
Copy link
Member Author

Related: ansible/team-devtools#78

@ofek
Copy link

ofek commented Dec 11, 2022

FYI it looks like this org wants to standardize on packaging and the first few migrated to Hatchling jazzband/help#313

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

build-backend = "setuptools.build_meta"

[project]
# https://peps.python.org/pep-0621/#readme
requires-python = ">=3.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder is there any decent pyproject.toml formatter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, prettier, i will configure it after this gets in.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssbarnea ssbarnea merged commit ba59404 into jazzband:main Dec 11, 2022
@ssbarnea ssbarnea deleted the fix/pep-621 branch December 11, 2022 16:16
q0w pushed a commit to q0w/pip-tools that referenced this pull request Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants