Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt user to use the backtracking resolver on errors #1719

Merged
merged 10 commits into from
Nov 10, 2022
Merged

Prompt user to use the backtracking resolver on errors #1719

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e8ec657
Prompt to use the backtracking resolver
maxfenv Nov 8, 2022
a796d6d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 8, 2022
0dca6e6
Test that user is prompted for backtracking
maxfenv Nov 9, 2022
02972d6
Keep line lengths below 80 chars
maxfenv Nov 9, 2022
cc7e396
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 9, 2022
62adf03
Improve test_failure_of_legacy_resolver_prompts_for_backtracking
atugushev Nov 9, 2022
6997cc4
Merge pull request #1 from atugushev/pr/1719-1
maxfenv Nov 10, 2022
2355215
Exclude branch from test coverage
maxfenv Nov 10, 2022
2d2e8f5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 10, 2022
37836df
Merge branch 'master' into prompt-for-backtracking
atugushev Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion piptools/scripts/compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

from .._compat import IS_CLICK_VER_8_PLUS, parse_requirements
from ..cache import DependencyCache
from ..exceptions import PipToolsError
from ..exceptions import NoCandidateFound, PipToolsError
from ..locations import CACHE_DIR
from ..logging import log
from ..repositories import LocalRequirementsRepository, PyPIRepository
Expand Down Expand Up @@ -545,6 +545,14 @@ def cli(
)
results = resolver.resolve(max_rounds=max_rounds)
hashes = resolver.resolve_hashes(results) if generate_hashes else None
except NoCandidateFound as e:
if resolver_cls == LegacyResolver:
maxfenv marked this conversation as resolved.
Show resolved Hide resolved
log.error(
"Using legacy resolver. Consider using backtracking resolver with --resolver=backtracking"
maxfenv marked this conversation as resolved.
Show resolved Hide resolved
)

log.error(str(e))
sys.exit(2)
except PipToolsError as e:
log.error(str(e))
sys.exit(2)
Expand Down