Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use tmp_path for test_override_newline #1694

Merged
merged 2 commits into from
Oct 8, 2022
Merged

use tmp_path for test_override_newline #1694

merged 2 commits into from
Oct 8, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 7, 2022 •
edited

Follow up to #1652

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@graingert graingert force-pushed the tmp-path-fixture branch 2 times, most recently from 7cbb5d5 to 0cf8f65 Compare October 7, 2022 12:29
@graingert graingert added the skip-changelog Avoid listing in changelog label Oct 7, 2022
@graingert graingert marked this pull request as ready for review October 7, 2022 13:03
@graingert graingert mentioned this pull request Oct 7, 2022
Merged
4 tasks
@graingert graingert added this to the 6.10.0 milestone Oct 7, 2022
@graingert
Copy link
Member Author

weird CI failure: #1697

@graingert graingert closed this Oct 8, 2022
@graingert graingert reopened this Oct 8, 2022
@webknjaz webknjaz merged commit 9a09482 into jazzband:master Oct 8, 2022
@graingert graingert deleted the tmp-path-fixture branch October 8, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
6.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @webknjaz