Add regression test for GH-1647 #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test that this fails prior to the fix #1649: $ git checkout --detach test-compile-cached-vcs
$ git rebase --onto 40d4818~ "$(git merge-base master HEAD)" HEAD
$ tox -e py310-piplatest-coverage -- -n 0 --no-cov -v tests/test_cli_compile.py::test_compile_cached_vcs_package |
webknjaz
reviewed
Oct 4, 2022
| ).stdout | ||
| ) | ||
|
|
||
| with open("requirements.in", "w") as req_in: |
There was a problem hiding this comment.
Why is this written to the project root?
There was a problem hiding this comment.
Not sure. I just followed the pattern used already for the other tests.
For Windows support, this includes workarounds for python/cpython#85815.
|
I rebased onto |
dand-oss
pushed a commit
to dand-oss/pip-tools
that referenced
this pull request
Nov 12, 2022
For Windows support, this includes workarounds for python/cpython#85815.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1686.
This asserts that the package is cached to avoid the problem with the prior test (where it passed when it should have failed—see #1649 (comment)).
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.