Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml & modern packaging to introduction. #1668

Merged
merged 12 commits into from Aug 13, 2022
Merged

Add pyproject.toml & modern packaging to introduction. #1668

merged 12 commits into from Aug 13, 2022

Conversation

hynek
Copy link
Contributor

@hynek hynek commented Aug 12, 2022

I have been surprised by the fact that pip-tools in fact does support pyproject.toml files, because the README is pretending like setup.py is the best way to go.

I've tried to somewhat rewrite it and point people to the new standard – let me know what you think.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few notes that may need addressing.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@atugushev atugushev added the docs Documentation related label Aug 12, 2022
hynek and others added 9 commits August 13, 2022 11:41
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@hynek hynek requested a review from webknjaz August 13, 2022 09:53
README.rst Outdated Show resolved Hide resolved
hynek and others added 2 commits August 13, 2022 12:21
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
@hynek
Copy link
Contributor Author

hynek commented Aug 13, 2022

I have added a change to the help string of pip-compile.

@webknjaz webknjaz merged commit 9e6bd8e into jazzband:master Aug 13, 2022
@hynek hynek deleted the intro-standards branch August 15, 2022 06:13
@atugushev atugushev added this to the 6.9.0 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants