Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --newline=[LF|CRLF|native|preserve] option to pip-compile #1652

Merged
merged 4 commits into from
Oct 5, 2022
Merged

Add --newline=[LF|CRLF|native|preserve] option to pip-compile #1652

merged 4 commits into from
Oct 5, 2022

Commits on Oct 3, 2022

  1. Add --newline [LF|CRLF|native|preserve] option to compile 

    - Use it in writer to override the line sep used in output, using io.TextIOWrapper
- Set default to preserve, which checks the output file, then the input file(s)
- Falls back to LF if that's not possible
    @AndydeCleyre
    AndydeCleyre committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2af5c3e View commit details
    Browse the repository at this point in the history

  2. Add tests for --newline option

    @AndydeCleyre
    AndydeCleyre committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    16ce7ca View commit details
    Browse the repository at this point in the history

  3. Move linesep determination to a dedicated function, with improvements 

    - skip decode to save time
- catch FileNotFoundError to avoid potential race condition

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
    @AndydeCleyre @graingert
    AndydeCleyre and graingert committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a55c423 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Merge branch 'master' into feature/linesep-textiowrapper

    @ssbarnea
    ssbarnea committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    eb46521 View commit details
    Browse the repository at this point in the history