Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file #1643

Merged
merged 9 commits into from
Nov 17, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,15 @@ jobs:
run: |
python -m pip install -U pip
python -m pip install -U setuptools twine wheel
# pip-tools can be built using `build` with the new pyproject.toml file
# python -m pip install -U twine build # setuptools and wheel are installed by build

- name: Build package
run: |
python setup.py --version
python setup.py sdist --format=gztar bdist_wheel
# pip-tools can be built using `build` with the new pyproject.toml file
ssbarnea marked this conversation as resolved.
Show resolved Hide resolved
# python -m build
otherJL0 marked this conversation as resolved.
Show resolved Hide resolved
twine check dist/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--strict wouldn't hurt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact adding strict would require fixing another bug, that is why I did not mention it during review.


- name: Upload packages to Jazzband
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system] # allows user to build pip-tools using pyproject-build or python -m build
requires = ["setuptools>=45", "setuptools_scm[toml]>=6.2", "wheel"]
otherJL0 marked this conversation as resolved.
Show resolved Hide resolved
build-backend = "setuptools.build_meta"