Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace direct usage of the pep517 module with the build module, for loading project metadata #1629

Merged
merged 7 commits into from Jun 15, 2022
Merged

Replace direct usage of the pep517 module with the build module, for loading project metadata #1629

merged 7 commits into from Jun 15, 2022

Conversation

AndydeCleyre
Copy link
Contributor

@AndydeCleyre AndydeCleyre commented May 25, 2022 •
edited by atugushev

The build module is better supported at this time, and going forward.

The change looks straightforward, except for dropped support of setup.cfg-only projects.

From the build changelog:

As a side-effect of PR #260, projects not containing either a pyproject.toml or setup.py will be reported as invalid. This affects projects specifying only a setup.cfg, such projects are recommended to add a pyproject.toml. The new behavior is on par with what pip currently does, so if you are affected by this, your project should not be pip installable.

So should pip-tools also drop support for setup.cfg-only projects, and adjust our test case projects accordingly?

That's what I'm going to do in this PR until/unless someone objects.

Fixes:

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@AndydeCleyre AndydeCleyre mentioned this pull request May 25, 2022
Closed
@AndydeCleyre AndydeCleyre marked this pull request as ready for review May 25, 2022 20:37
@AndydeCleyre AndydeCleyre mentioned this pull request May 29, 2022
Closed
@AndydeCleyre
Replace use of pep517 directly with build
77f7ce4 
The build module is better supported at this time and going forward
@AndydeCleyre
make_module: Add minimal pyproject.toml when otherwise setup.cfg-only
0869c09 
From the `build` changelog:

> ... projects not containing either a `pyproject.toml` or `setup.py`
will be reported as invalid. This affects projects specifying only a
`setup.cfg`, such projects are recommended to add a `pyproject.toml`.
@AndydeCleyre
Expect success for pypy tests affected by jazzband#1375
dbfb66d
@AndydeCleyre
Expect success for pypy test affected by jazzband#1148
084d2bc
@AndydeCleyre
Catch BuildBackendException; plainly report error
bbf5121
@AndydeCleyre
Add test: invalid setup.py parse failure handling
e3b29a8
atugushev
atugushev approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Most API in pep517 is deprecated in favor of build. Thanks for the improvement 🎉

@atugushev atugushev added the dependency Related to a dependency label Jun 4, 2022
@atugushev atugushev changed the title Replace direct usage of the pep517 module with the build module, for loading project metadata Replace direct usage of the pep517 module with the build module, for loading project metadata Jun 4, 2022
@atugushev atugushev merged commit 588c050 into jazzband:master Jun 15, 2022
@AndydeCleyre AndydeCleyre linked an issue Jun 17, 2022 that may be closed by this pull request
Use of (Deprecated) pep517 Package Hides setup.py Syntax Errors #1627
Closed
@atugushev atugushev added this to the 6.7.0 milestone Jun 26, 2022
@atugushev atugushev mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
dependency Related to a dependency
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

Use of (Deprecated) pep517 Package Hides setup.py Syntax Errors
2 participants
@AndydeCleyre @atugushev