Ensure pip-compile --dry-run --quiet still shows what would be done, while omitting the dry run message
#1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atugushev
approved these changes
Mar 4, 2022
AndydeCleyre
changed the title
pip-compile --dry-run --quiet logs the result (without the dry run message) to stderrpip-compile --dry-run --quiet still shows what would be done, while omitting the dry run message
AndydeCleyre
force-pushed
the
bugfix/845
branch
from
251c260
to
bf7a785
Compare
AndydeCleyre
force-pushed
the
bugfix/845
branch
2 times, most recently
from
9ed3f82
to
0daecfa
Compare
|
@AndydeCleyre feel free to merge this. I'm going to release this as part of 6.6.0 soon. |
- content to stderr - omit the dry run message Fixes jazzband#845
|
Thanks, I'll merge if the Actions queue ever gets sorted and I get back to this first. I cancelled unnecessary jobs from my own PRs to clear the way, but the CI queue is in a bad mood today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845
Original title: "Ensure
pip-compile --dry-run --quietlogs the result (without the dry run message) to stderr"As the purpose of
--dry-runaccording to our--helpdocs is to "...show what would happen...", that bit of logging should not be silenced by--quiet, so we herein bypass the log level filtering by usinglog.lograther thanlog.infofor the output during dry runs.The corresponding dry+quiet test has been updated accordingly.
I also changed our basic testing of
--quietby removing the--dry-runoption and additionally checking that stdout is empty.Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.