Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve punctuation/grammar with pip-compile header #1547

Merged
merged 7 commits into from Nov 20, 2022

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Dec 26, 2021

Resolves #1636.

Contributor checklist
  • Provided the tests for the changes.

There are outdated references in the README etc.

  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

piptools/writer.py Outdated Show resolved Hide resolved
@atugushev
Copy link
Member

We might want to rephrase the whole "To update run:" line, see the details #1636.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@ssbarnea ssbarnea added the bug Something is not working label Oct 6, 2022
@ssbarnea ssbarnea added this to the 6.10.0 milestone Oct 6, 2022
@atugushev
Copy link
Member

Perhaps we should address this issue together with #1636 to update the header in one shot?

@atugushev atugushev removed this from the 6.10.0 milestone Nov 11, 2022
piptools/writer.py Outdated Show resolved Hide resolved
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
@ssbarnea ssbarnea enabled auto-merge (squash) November 20, 2022 17:07
@atugushev atugushev added the writer Related to results output writer component label Nov 20, 2022
@atugushev atugushev added this to the 6.11.0 milestone Nov 20, 2022
@ssbarnea ssbarnea merged commit 7957dc9 into jazzband:master Nov 20, 2022
@atugushev atugushev changed the title Improve punctuation/grammar with header. Improve punctuation/grammar with pip-compile header Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working writer Related to results output writer component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The banner in the generated requirements.txt is confusing
4 participants