Fixing issue with losing data about local files #1385
Conversation
microcat49
force-pushed
the
1054_pip-compile_does_not_work_for_vsphere-automation-sdk-python_setup.py_on_GitHub
branch
2 times, most recently
from
d8c090e
to
d1c6629
Compare
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
==========================================
- Coverage 99.67% 99.47% -0.20%
==========================================
Files 33 33
Lines 3037 3055 +18
Branches 327 330 +3
==========================================
+ Hits 3027 3039 +12
- Misses 5 8 +3
- Partials 5 8 +3
Continue to review full report at Codecov.
|
When a dependency is a local file we need to keep track of that information. During the combine_install_requirements function we were losing that information. This merge request looks for that information and combines it into the InstallRequirements object that is going to be returned by that function.
microcat49
force-pushed
the
1054_pip-compile_does_not_work_for_vsphere-automation-sdk-python_setup.py_on_GitHub
branch
from
064baf9
to
b6db3f9
Compare
|
@atugushev sorry about the delayed response. I think the 3.10 python test failure is due to something that is not related to my code. This PR is ready for review. |
|
Is there anything that could be done to get this pull request moving forward? |
|
Thanks! Can you please rebase this onto latest master? And if this is intended to fix #1054, please add such a note to the top post. |
|
Are you still available to work on this? Or should I take your work (author-preserved) to a new PR for further work? |
|
ping @microcat49 |
|
I'm going to close this in favor of focusing related attention on #1519. Thank you for this, and please let me know if something's amiss! |
Fixes the loss of information in resolver where we were not keeping track of the InstallRequirements local file information.
Contributor checklist