New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up caching PyPI deps in GHA #1378
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@webknjaz It would be great to follow patterns that we've established in other Jazzband repos, e.g. the pip cache dir should not be hardcoded here. Instead use |
@jezdez got it, thanks for the feedback! I think I copied this from one of my projects where |
Gotcha, we switched to that CLI call only a bit ago when pip gained this subcommand, so no worries! |
pip can now be cached via https://github.com/actions/setup-python#caching-packages-dependencies Please see #1571 for an alternative. |
Ref #1375 (comment)
Changelog-friendly one-liner: Made GHA workflows faster by enabling pip cache
Contributor checklist