Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to several areas where straightforward #1315

Merged
merged 1 commit into from Feb 7, 2021
Merged

Add typing to several areas where straightforward #1315

merged 1 commit into from Feb 7, 2021

Conversation

jdufresne
Copy link
Member

@jdufresne jdufresne commented Feb 6, 2021

Refs: #972

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #1315 (6e8017f) into master (d9f50f1) will decrease coverage by 0.06%.
The diff coverage is 97.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   99.65%   99.58%   -0.07%     
==========================================
  Files          33       33              
  Lines        2889     2907      +18     
  Branches      320      321       +1     
==========================================
+ Hits         2879     2895      +16     
- Misses          5        6       +1     
- Partials        5        6       +1     
Impacted Files Coverage Δ
piptools/resolver.py 98.12% <71.42%> (-1.24%) ⬇️
piptools/__main__.py 100.00% <100.00%> (ø)
piptools/cache.py 100.00% <100.00%> (ø)
piptools/exceptions.py 100.00% <100.00%> (ø)
piptools/logging.py 100.00% <100.00%> (ø)
piptools/repositories/base.py 100.00% <100.00%> (ø)
piptools/sync.py 100.00% <100.00%> (ø)
piptools/utils.py 100.00% <100.00%> (ø)
tests/test_cache.py 100.00% <100.00%> (ø)
tests/test_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f50f1...2c1c4c1. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment below. Otherwise, LGTM 👍🏼

piptools/exceptions.py Outdated Show resolved Hide resolved
@atugushev atugushev mentioned this pull request Feb 7, 2021
16 tasks
@jdufresne jdufresne merged commit d63ac9b into jazzband:master Feb 7, 2021
@jdufresne jdufresne deleted the more-type-hints branch February 7, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants