Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for the writer module #1310

Merged
merged 1 commit into from Feb 6, 2021

Conversation

atugushev
Copy link
Member

Refs: #972

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1310 (8f2755b) into master (4776ac9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1310   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          33       33           
  Lines        2880     2889    +9     
  Branches      320      320           
=======================================
+ Hits         2870     2879    +9     
  Misses          5        5           
  Partials        5        5           
Impacted Files Coverage Δ
piptools/logging.py 100.00% <100.00%> (ø)
piptools/utils.py 100.00% <100.00%> (ø)
piptools/writer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4776ac9...8f2755b. Read the comment docs.

@atugushev atugushev mentioned this pull request Feb 4, 2021
16 tasks
@codingjoe codingjoe linked an issue Feb 5, 2021 that may be closed by this pull request
16 tasks
Copy link
Member

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the ball rolling!

@atugushev atugushev merged commit d9f50f1 into jazzband:master Feb 6, 2021
@atugushev atugushev deleted the typehints-for-writer branch February 6, 2021 07:17
@atugushev
Copy link
Member Author

Thank you for reviewing this @jdufresne 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotations
2 participants