Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-reuse-hashes to COMPILE_EXCLUDE_OPTIONS #1197

Merged
merged 2 commits into from Aug 23, 2020

Conversation

graingert
Copy link
Member

Changelog-friendly one-liner:

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev
Copy link
Member

Hello @graingert,

Thanks for your contribution! Could you please elaborate on the motivation for the change?

@graingert
Copy link
Member Author

graingert commented Aug 6, 2020

Imho "--no-reuse-hashes" is a runtime only flag for the same reasons as "--rebuild"

@atugushev atugushev changed the title add --no-reuse-hashes to COMPILE_EXCLUDE_OPTIONS Add --no-reuse-hashes to COMPILE_EXCLUDE_OPTIONS Aug 19, 2020
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable 👍

@atugushev atugushev added the enhancement Improvements to functionality label Aug 19, 2020
@atugushev atugushev added this to the 5.4.0 milestone Aug 23, 2020
@atugushev atugushev merged commit 61eb515 into jazzband:master Aug 23, 2020
@graingert graingert deleted the patch-4 branch August 28, 2020 11:01
@graingert
Copy link
Member Author

@atugushev can I get a release for this please?

mjsir911 added a commit to terrapower/pip-tools that referenced this pull request Mar 5, 2024
Fixes: jazzband#2065
See: jazzband#1197

Click context only had positive --reuse-hashes to loop over, inverse is
automatically deduced.
mjsir911 added a commit to terrapower/pip-tools that referenced this pull request Mar 5, 2024
Fixes: jazzband#2065
See: jazzband#1197

This is specifically for the --no-reuse-hashes found in
COMPILE_EXCLUDE_OPTIONS but makes way for future inverse flags in the
list too.
mjsir911 added a commit to terrapower/pip-tools that referenced this pull request Mar 5, 2024
…eader

Fixes: jazzband#2065
See: jazzband#1197

This is specifically for the --no-reuse-hashes found in
COMPILE_EXCLUDE_OPTIONS but makes way for future inverse flags in the
list too.
mjsir911 added a commit to terrapower/pip-tools that referenced this pull request Mar 5, 2024
…eader

Fixes: jazzband#2065
See: jazzband#1197

This is specifically for the --no-reuse-hashes found in
COMPILE_EXCLUDE_OPTIONS but makes way for future inverse flags in the
list too.
mjsir911 added a commit to terrapower/pip-tools that referenced this pull request Mar 6, 2024
…header

Fixes: jazzband#2065
See: jazzband#1197

This is specifically for the --no-reuse-hashes found in
COMPILE_EXCLUDE_OPTIONS but makes way for future inverse flags in the
list too.
mjsir911 added a commit to terrapower/pip-tools that referenced this pull request Mar 11, 2024
Fixes: jazzband#2065
See: jazzband#1197

This is specifically for the --no-reuse-hashes found in
COMPILE_EXCLUDE_OPTIONS but makes way for future inverse flags in the
list too.
hauntsaninja pushed a commit to hauntsaninja/pip-tools that referenced this pull request Mar 25, 2024
Fixes: jazzband#2065
See: jazzband#1197

This is specifically for the --no-reuse-hashes found in
COMPILE_EXCLUDE_OPTIONS but makes way for future inverse flags in the
list too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants