Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --emit-options/--no-emit-options flags to pip-compile #1123

Merged
merged 3 commits into from Jun 20, 2021

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Apr 27, 2020

Description

A switcher to turn off all options in the compile output.

Rationale

  1. It might be helpful for users who have pip.conf and don't want to pass any options to the compile output. Yes, they can switch off some of the options with --no-emit-trusted-hosts and --no-emit-find-links, but there is no option to turn them all off.

  2. Also, it's pretty useful for the tests to check the exact resolver output. For example, instead of:

out = invoke(cli)
assert "small-fake-a==0.1" in out.stderr

check the complete result and make sure that there are no side dependencies

out = invoke(cli, ["--no-annotate", "--no-emit-options"])
assert out.stderr.splitlines() == ["small-fake-a==0.1"]

Changelog-friendly one-liner: Add --emit-options/--no-emit-options flag to pip-compile.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the enhancement Improvements to functionality label Apr 27, 2020
@codecov

This comment has been minimized.

@atugushev atugushev marked this pull request as ready for review May 2, 2020 06:01
@atugushev atugushev added the cli Related to command line interface things label May 2, 2020
@ssbarnea
Copy link
Member

@atugushev Can you please rebase it and eventually mark it as draft if is not passing CI? Thanks.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atugushev LGTM but please fix conflicts.

@ssbarnea ssbarnea requested a review from webknjaz June 19, 2021 11:46
@ssbarnea ssbarnea added this to the 6.2.0 milestone Jun 20, 2021
@ssbarnea ssbarnea merged commit 295ba86 into jazzband:master Jun 20, 2021
@atugushev atugushev changed the title Add --emit-options/--no-emit-options flag Add --emit-options/--no-emit-options flags to pip-compile Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to command line interface things enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants