Clarify intent of extra=None

jazzband · Feb 13, 2021 · 3a53732 · 3a53732
1 parent 040be7c
commit 3a53732
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/piptools/scripts/compile.py b/piptools/scripts/compile.py
@@ -429,7 +429,11 @@ def cli(
     constraints = [
         req
         for req in constraints
-        if req.markers is None or req.markers.evaluate(dict(extra=None))
+        if req.markers is None
+        # We explicitly set extra=None to filter out optional requirements
+        # since evaluating an extra marker with no environment raises UndefinedEnvironmentName
+        # (see https://packaging.pypa.io/en/latest/markers.html#usage)
+        or req.markers.evaluate(dict(extra=None))
     ]
 
     log.debug("Using indexes:")