Revert "refactor: Move registry.get_methods() call to separate method, to all…" #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to allow customization" This reverts commit 8d1ecfe.
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 95.47% 95.47% -0.01%
==========================================
Files 75 75
Lines 3204 3202 -2
Branches 359 359
==========================================
- Hits 3059 3057 -2
Misses 116 116
Partials 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #535
This worked fine for simpler cases, but in the end turned out to be useless.
We instead decided to monkey-patch MethodRegistry, and filter choices there, because everything already uses registry.get_methods.