refactor!(settings): Simplify settings structure for pytest #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 79.85% 82.19% +2.34%
==========================================
Files 7 7
Lines 134 146 +12
Branches 13 13
==========================================
+ Hits 107 120 +13
Misses 20 20
+ Partials 7 6 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
simplify-settings
branch
2 times, most recently
from
c312edd
to
973d1cb
Compare
tony
force-pushed
the
simplify-settings
branch
from
973d1cb
to
c75515f
Compare
tony
commented
Oct 15, 2022
|
|
||
|
|
||
| sys.modules[__name__] = Settings() |
There was a problem hiding this comment.
sys.modules[__name__] = Settings()
This is what throws off pytest collection in #137 (as of pytest 7.1.3)
tony
force-pushed
the
simplify-settings
branch
from
34b12b7
to
2639128
Compare
tony
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139