Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare next release #342

Draft
wants to merge 64 commits into
base: master
Choose a base branch
from
Draft

Prepare next release #342

wants to merge 64 commits into from

Conversation

johnraz
Copy link
Collaborator

@johnraz johnraz commented May 2, 2024

Some things that need to be done before develop is ready:

  • Changelog should be updated
  • Base on the changelog update a version should be promoted
  • A task to generate the documentation and publish the github page should be put in place
  • Access to the pypi registry should be gained

Keep this PR in draft until the above are done

@James1345 @giovannicimolin

belugame and others added 30 commits January 31, 2022 16:28
fix  django.db.migrations.exceptions.IrreversibleError: Operation <RunPython <function cleanup_tokens at 0x0000027CCB764820>> in knox.0006_auto_20160818_0932 is not reversible error when python manage,py migrate knox zero on django 4.0.4
Changes made were done to make the README.md easy to read.
* Allowed usage of custom AuthToken based on knox.AbstractAuthToken

* moved get_token_model() to models, updated the docs

Co-authored-by: Khalidm98 <khalid.refaat@gmail.com>
…etup

test: Set up pre-commit hooks and fix quality nits
updates:
- [github.com/PyCQA/isort: 5.11.5 → 5.12.0](PyCQA/isort@5.11.5...5.12.0)
[doc] improve readability of example code
giovannicimolin and others added 18 commits October 17, 2023 08:18
Enable customizing login/logout responses
updates:
- [github.com/PyCQA/isort: 5.12.0 → 5.13.2](PyCQA/isort@5.12.0...5.13.2)
- [github.com/PyCQA/flake8: 6.1.0 → 7.0.0](PyCQA/flake8@6.1.0...7.0.0)
feat(ci): add current django and python to test
chore(migration): use f-string
refactor(auth): Use `self.authenticate_header()` in `authenticate()` method to get auth header prefix
`setting_changed` is actually from `django.core.signals`, and is re-exported from `django.test.signals`. `django.test` takes 20-40ms to import, so not too much, but it's an easy win to avoid this import.
@giovannicimolin
Copy link
Contributor

Implemented the CI job to automatically push documentation updates: #343

@giovannicimolin
Copy link
Contributor

Also, referencing the discussion on #304:

  1. Jazzband was invited to be a maintainer of this repo on Pypi.
  2. Implement Jazzband guidelines for django-rest-knox #304 (comment): Let's use develop as the new main branch and use tags for Pypi versions.

@johnraz
Copy link
Collaborator Author

johnraz commented May 7, 2024

In the scope of this new release I'd like to suggest that we maintain a changelog and require every PR to add content to it.

In order to make the process as streamlined and conflict free as possible, I'd like to suggest the following tool -> https://changie.dev/ - thoughts?

@calumy calumy mentioned this pull request May 7, 2024
@giovannicimolin
Copy link
Contributor

@johnraz Oh, that's a neat tool!

I need to catch up the changelog with the merges though, there's quite a few things that were merged but are missing from there (all minor things or fixes though).
We still haven't got Pypi access, so I'm thinking of creating a mirror repo just to unblock releases until that is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet