Add Paydirekt provider #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (allows much more freedom) and adjust all providers for the change use create_test_payment for tests, TestPayment is now a Mock use unittest mocks when python3
…ainst invalid callback (which seems to appear)
…lable, TODO: fix bug
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 79.13% 79.22% +0.08%
==========================================
Files 27 29 +2
Lines 1649 1993 +344
Branches 190 234 +44
==========================================
+ Hits 1305 1579 +274
- Misses 245 292 +47
- Partials 99 122 +23
Continue to review full report at Codecov.
|
|
Thank you for this contribution. I think we'd prefer for new payment providers to live in their own packages. In fact we've discussed splitting the current main package. Please take a look at https://github.com/esistgut/django-payments-bnlepos for an externally-maintained payment provider. |
|
good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a backend for paydirekt.
It depends on some other pullrequests of mine:
#148 #149
Sry for the long commit history. I required the backend for a project.