Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary GitHub Graph info #1910

Merged
merged 2 commits into from Apr 30, 2024
Merged

Conversation

jeffwidman
Copy link
Contributor

This code is no longer needed now that the GitHub dependency graph shipped support for pyproject.toml: https://github.com/orgs/community/discussions/6456#discussioncomment-5244057

I didn't include a changelog mention as this is not a user-facing change.

jeffwidman and others added 2 commits April 23, 2024 19:14
This code is no longer needed now that the GitHub dependency graph shipped support for `pyproject.toml`: https://github.com/orgs/community/discussions/6456#discussioncomment-5244057
@jeffwidman
Copy link
Contributor Author

Optionally, could simply nuke setup.py entirely, as most folks have moved to pip install, and those who haven't probably have a very specific reason/know how to handle the error that happens when they try it.

cc @ofek as I spotted this in your PR here: https://github.com/jazzband/django-debug-toolbar/pull/1690/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R18-R23

I was gratuitously plagiarizing from it to update some other OSS Python libs when I saw this bit of code... I know you've updated a ton of other repos, so just FYI.

@ofek
Copy link
Contributor

ofek commented Apr 24, 2024

Great to know, thank you!

@tim-schilling tim-schilling merged commit 2134600 into jazzband:main Apr 30, 2024
26 checks passed
@jeffwidman jeffwidman deleted the patch-1 branch April 30, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants