Make tox pass selenium environment variables #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tox, pass through the user's DISPLAY and
DJANGO_SELENIUM_TESTS environment variables, so that
DJANGO_SELENIUM_TESTS=true tox
will actually run the Selenuim integration tests. Without this change,
the test suite never sees the DJANGO_SELENIUM_TESTS variable and thus
skips the integration tests. Without DISPLAY, the integration tests
will error out (unless CI is present in the environment to instruct the
test suite to run the Selenium webdriver in headless mode).
|
I think we previously left the selenium tests off because they're a bit burdensome to run locally. |
matthiask
approved these changes
Mar 11, 2024
|
Yes, this PR isn't changing that default, it is just making it possible to enable them through tox if desired. Right now the Contributing docs includes the following snippet:
The first two lines using |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running tox, pass through the user's
DISPLAYandDJANGO_SELENIUM_TESTSenvironment variables, so thatwill actually run the Selenuim integration tests. Without this change, the test suite never sees the
DJANGO_SELENIUM_TESTSvariable and thus skips the integration tests. WithoutDISPLAY, the integration tests will error out (unlessCIis present in the environment to instruct the test suite to run the Selenium webdriver in headless mode).Checklist:
docs/changes.rst.