1847 improve handling when djdt views dont respond with json #1877

elineda · 2024-02-06T09:22:50Z

Description

Put a better error message when the response of the toolbar request is not a proper json object.

For test it, add after line 48 of debug_toolbar/middleware.py

from django.shortcuts import redirect
return redirect('admin:login')

Fixes #1847

[m] add a catch for catch json error and display it with a better message

…espond-with-json

[m] Put a better response [+] Add changelog

for more information, see https://pre-commit.ci

debug_toolbar/static/debug_toolbar/js/utils.js

docs/changes.rst

…espond-with-json

elineda added 3 commits February 1, 2024 11:26

Improve handling when DJDT views don't respond with JSON

c284df1

[m] add a catch for catch json error and display it with a better message

Merge branch 'main' into 1847-improve-handling-when-djdt-views-dont-r…

d7120c1

…espond-with-json

Improve handling when DJDT views don't respond with JSON

eb53b01

[m] Put a better response [+] Add changelog

elineda self-assigned this Feb 6, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

016d794

for more information, see https://pre-commit.ci

matthiask reviewed Feb 6, 2024

View reviewed changes

debug_toolbar/static/debug_toolbar/js/utils.js Show resolved Hide resolved

sarahboyce added the Djangonaut Space 🚀 label Feb 6, 2024

tim-schilling reviewed Feb 22, 2024

View reviewed changes

docs/changes.rst Outdated Show resolved Hide resolved

tim-schilling added 2 commits February 22, 2024 13:44

Update docs/changes.rst

fc87adb

Merge branch 'main' into 1847-improve-handling-when-djdt-views-dont-r…

acdd863

…espond-with-json

matthiask merged commit 9f66bd3 into jazzband:main Feb 22, 2024
20 of 25 checks passed