Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Redis history #1763

Closed
wants to merge 5 commits into from
Closed

add Redis history #1763

wants to merge 5 commits into from

Conversation

ivanyshchuk
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. Your commit message should include
this information as well.

Fixes # (issue)

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@ivanyshchuk ivanyshchuk reopened this Apr 13, 2023
@matthiask
Copy link
Member

Thank you! If I understand it correctly you want to persist the toolbar's state in the cache instead of the local memory, correct? We have been discussing approaches here: #1432

@matthiask
Copy link
Member

I'm going to reject this as it is currently since we have discussed a slightly different approach which we want to pursue.

Also, tests are failing and there hasn't been any response to my comments.

It's not a rejection of the feature, just a rejection of this particular pull request. Thanks!

@matthiask matthiask closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants