Allow per-DB port specification for tox #1753
Conversation
As currently written, tox.ini allows specifying the DB port to use to connect to the test DB using a DB_PORT environment variable. However, it uses the same variable for the mysql, postgresql, and postgis environments. Thus if specifying a custom DB_PORT environment variable when running the full combination of tox environments, the mysql, postgresql, and postgis environments will all attempt to use the same DB port, which is unlikely to result in happiness. Fix by checking for three new environment variables, POSTGRESQL_DB_PORT, POSTGIS_DB_PORT, and MYSQL_DB_PORT in the respective environments, falling back to DB_PORT (and then the hard-coded default) for backwards compatibility.
There was a problem hiding this comment.
I'm not sure I understand the tox documentation fully but maybe factors or something could help with this; if a database environment is a factor (is it?) couldn't you run tox once per DB environment without having to list all individual combinations explicitly?
|
The following commands seem to produce the correct list of environments for the given databases:
|
|
Thanks for those commands. Unfortunately they only work with tox 4.x, and I have to stay with tox 3.x for the moment due to some other projects. I'd still like to be able to just run the full test suite with just a single tox invocation, although using the |
|
So my changes in this PR didn't work with tox 4.x due to tox-dev/tox#2972. Closing. |
As currently written, tox.ini allows specifying the DB port to use to connect to the test DB using a
DB_PORTenvironment variable. However, it uses the same variable for the mysql, postgresql, and postgis environments. Thus if specifying a customDB_PORTenvironment variable when running the full combination of tox environments, the mysql, postgresql, and postgis environments will all attempt to use the same DB port, which is unlikely to result in happiness.Fix by checking for three new environment variables,
POSTGRESQL_DB_PORT,POSTGIS_DB_PORT, andMYSQL_DB_PORTin the respective environments, falling back toDB_PORT(and then the hard-coded default) for backwards compatibility.The motivation for this change is that I wanted to run postgresql within a container listening on a non-standard port for testing, but didn't have a way to run all tox over all the environments while setting the port for postgresql/postgis without also affecting the port for mysql.
docs/changes.rst.