Allow Language Selection on the Toolbar #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
approved these changes
Nov 11, 2022
Allows users to define the language that the toolbar will be rendered using the new settings `TOOLBAR_LANGUAGE` Adds test cases to TOOLBAR_LANGUAGE setting Removes trailing setting on example project
tim-schilling
force-pushed
the
991-toolbar-language-selection
branch
from
dcf1e33
to
d9b25f2
Compare
|
Squashed your commits. |
matthiask
added a commit
that referenced
this pull request
Jan 16, 2023
* Use correct language in panels PR #1703 introduced a bug where SQLPanel (and probably others) is rendered in `LANGUAGE_CODE` language, while it should use `TOOLBAR_LANGUAGE` if provided. This PR fixes panel's content language. * Add missing changelog entries * Use code formatting and include more details on the recent change. * Create decorator to use TOOLBAR_LANGUAGE in toolbar specific views. This reviews the third-party panel documentation to reference these two decorators and explain them. They aren't necessary but should be used. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Schilling <schillingt@better-simple.com> Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #991
Added a new optional setting
TOOLBAR_LANGUAGEthat can be set by a user to define in which language the toolbar is displayed.Modified the
render_toolbarmethod fromDebugToolbarclass to use thedjango.utils.translations.override, so the language is set either: To the defined language on theTOOLBAR_LANGUAGEor the current language (No breaking changes). After the template is rendered, the language is set back to the previous.Added two tests cases:
One that checks if the toolbar is rendered accordingly when this setting was not defined, the default behavior.
Other that checks if the toolbar was rendered to the set language.
Updated documentation on
configuration.rston how to set this value.