Include panel scripts in content when RENDER_PANELS=True #1689
Conversation
|
Addendum: My gut feeling is that this change is correct, I lean towards merging but I really want a second opinion. |
|
RENDER_PANELS is used when setting up an asgi app with channels. We should extend the example app to support testing that case, but not necessarily now. I can run this PR against a project of mine that uses ASGI next week if you can wait till then. |
|
Sure! No pressure at all. I added a |
Without marking them as modules, they weren't being loaded in as expected.
|
Alright this should be good now. I spotted a bug where the "inserted" statement I removed (when it was still in the code) wasn't being printed out. Making it a module script seems to have resolved the issue. I'll leave the last review, squash and merge to you if you don't have any questions. |
|
No questions, thanks for checking and for improving the test! |
It seems to me that panel scripts aren't included at all when using
RENDER_PANELS=Trueat the moment. This would probably be a bug. I don't useRENDER_PANELSanywhere and therefore cannot really test if this change would be correct.I found this while trying to write a test for the timer panel (because I wanted a green build, re. code coverage)