Reduce number of .settings calls and document config update.

jazzband · Apr 26, 2024 · 0e90884 · 0e90884
1 parent 9d906fb
commit 0e90884
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/tests/test_checks.py b/tests/test_checks.py
@@ -240,19 +240,21 @@ def test_check_w007_invalid(self, mocked_guess_type):
         )
 
     def test_debug_toolbar_installed_when_running_tests(self):
-        with self.settings(DEBUG=False):
-            dt_settings.get_config()["IS_RUNNING_TESTS"] = False
-            errors = debug_toolbar_installed_when_running_tests_check(None)
-            self.assertEqual(len(errors), 0)
         with self.settings(DEBUG=True):
+            # Update the config options because self.settings()
+            # would require redefining DEBUG_TOOLBAR_CONFIG entirely.
             dt_settings.get_config()["IS_RUNNING_TESTS"] = True
             errors = debug_toolbar_installed_when_running_tests_check(None)
             self.assertEqual(len(errors), 0)
-        with self.settings(DEBUG=True):
+
             dt_settings.get_config()["IS_RUNNING_TESTS"] = False
             errors = debug_toolbar_installed_when_running_tests_check(None)
             self.assertEqual(len(errors), 0)
         with self.settings(DEBUG=False):
+            dt_settings.get_config()["IS_RUNNING_TESTS"] = False
+            errors = debug_toolbar_installed_when_running_tests_check(None)
+            self.assertEqual(len(errors), 0)
+
             dt_settings.get_config()["IS_RUNNING_TESTS"] = True
             errors = debug_toolbar_installed_when_running_tests_check(None)
             self.assertEqual(