fix(bundling): fix esbuild build watch (nrwl#12448)

jaysoo · Oct 6, 2022 · 73a491a · 73a491a
1 parent 2405a2e
commit 73a491a
Showing 1 changed file with 39 additions and 40 deletions.
diff --git a/packages/esbuild/src/executors/esbuild/esbuild.impl.ts b/packages/esbuild/src/executors/esbuild/esbuild.impl.ts
@@ -57,46 +57,45 @@ export async function* esbuildExecutor(
               options,
               context
             );
-            const result = await esbuild.build({
-              ...esbuildOptions,
-              watch:
-                // Only emit info on one of the watch processes.
-                idx === 0
-                  ? {
-                      onRebuild: async (
-                        error: esbuild.BuildFailure,
-                        result: esbuild.BuildResult
-                      ) => {
-                        if (!options.skipTypeCheck) {
-                          const { errors } = await runTypeCheck(
-                            options,
-                            context
-                          );
-                          hasTypeErrors = errors.length > 0;
-                        }
-                        const success = !error && !hasTypeErrors;
-
-                        if (!success) {
-                          logger.info(BUILD_WATCH_FAILED);
-                        } else {
-                          logger.info(BUILD_WATCH_SUCCEEDED);
-                        }
-
-                        next({
-                          success: !!error && !hasTypeErrors,
-                          outfile: esbuildOptions.outfile,
-                        });
-                      },
-                    }
-                  : true,
-            });
-
-            next({
-              success,
-              outfile: esbuildOptions.outfile,
-            });
-
-            return result;
+            const watch =
+              // Only emit info on one of the watch processes.
+              idx === 0
+                ? {
+                    onRebuild: async (
+                      error: esbuild.BuildFailure,
+                      result: esbuild.BuildResult
+                    ) => {
+                      if (!options.skipTypeCheck) {
+                        const { errors } = await runTypeCheck(options, context);
+                        hasTypeErrors = errors.length > 0;
+                      }
+                      const success = !error && !hasTypeErrors;
+
+                      if (!success) {
+                        logger.info(BUILD_WATCH_FAILED);
+                      } else {
+                        logger.info(BUILD_WATCH_SUCCEEDED);
+                      }
+
+                      next({
+                        success: !!error && !hasTypeErrors,
+                        outfile: esbuildOptions.outfile,
+                      });
+                    },
+                  }
+                : true;
+            try {
+              const result = await esbuild.build({ ...esbuildOptions, watch });
+
+              next({
+                success: true,
+                outfile: esbuildOptions.outfile,
+              });
+
+              return result;
+            } catch {
+              next({ success: false });
+            }
           })
         );
         const processOnExit = () => {