Set a token default and support private repos #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-evans
commented
Oct 20, 2022
| `No GitHub token found` | ||
| ) | ||
| } | ||
| const token = process.env['GITHUB_TOKEN'] || core.getInput("token") |
There was a problem hiding this comment.
For backwards compatibility the environment variable is used if available. If not it falls back to the token input.
peter-evans
commented
Oct 20, 2022
| @@ -2,6 +2,9 @@ name: "Install a binary from GitHub releases" | |||
| description: "Install binaries from GitHub releases" | |||
| author: "Lee Briggs" | |||
| inputs: | |||
| token: | |||
| description: 'GITHUB_TOKEN or a `repo` scoped Personal Access Token (PAT)' | |||
| default: ${{ github.token }} | |||
There was a problem hiding this comment.
Defaults to GITHUB_TOKEN so users don't need to specify a token in workflows unless they want to access a private repository.
|
thanks for the awesome contribution! |
|
Thank you for maintaining this great action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to improve the interface and allow the action to work for private repositories.
tokeninput that defaults to the defaultGITHUB_TOKENin the repository.