Fix errors from concurrent builds with cache: enable #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test-driving
cache: enableat scale, pulumi/pulumi#9628 - it seems to work and result in cache hits, but sometimes there is a race with an exception on a cache miss:I'm borrowing some error-handling code here found in actions/cache repo https://github.com/actions/cache/blob/d55d005ab0cbd9310b447311bcd1661be90843f5/src/save.ts#L47
It should be OK to downgrade this to a warning; in the case of a race, the first-write-wins is fine. The key of the cache uniquely determines the binary version.