Adds opt-in caching #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
May 19, 2022
| await cache.saveCache([dest], cacheKey); | ||
| } | ||
|
|
||
| core.addPath(dest); |
There was a problem hiding this comment.
There is a change here even when not opting into the cache, the path where the tool is installed is changing from a random UUID path to a path under hostedtoolcache (RUNNER_TOOL_CACHE) based on owner, repo, version, architecture (dest var). I think this should be ok. hostedtoolcache is not preserved across GHA worker runs but may be preserved across self-hosted runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #21 long backoff on rate limit issues.
The opt-in cache avoids using oktokit API to scan releases and tags when there is a cache hit.
The downside is that this action becomes larger as it now links to actions/cache.