Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flexible release #19

Merged
merged 7 commits into from May 6, 2022

Conversation

phillipjf
Copy link
Contributor

@phillipjf phillipjf commented May 4, 2022

This PR adds functionality to support:

  • Custom OS Arch and Platform options as input to the action for matching release artifacts
  • More flexible artifact naming and matching based on OS Arch and Platform

this changes allows for user input to the action to specify the os arch and os platform as an override. it also updates the matching pattern to match more flexible naming.
@phillipjf
Copy link
Contributor Author

Hi @jaxxstorm please let me know if this is something to consider merging or any feedback is welcome. I reviewed the CONTRIBUTING.md guide but it does not seem applicable for this repository.

@jaxxstorm
Copy link
Owner

@phillipjf this looks awesome, thanks so much! I'll discuss with the team using it at Pulumi, this looks to be a breaking change to want to make sure we release appropriately.

@jaxxstorm
Copy link
Owner

@phillipjf would you mind adding some tests/integration tests for your changes?

@phillipjf
Copy link
Contributor Author

@jaxxstorm thanks for the reply. I'll take a look at getting some tests added. Is there a preference for framework/etc. within the org? There aren't any existing tests to base off of.

I also tried to make this change pretty backwards-compatible, so if you see anything breaking, I'm willing to update to accommodate.

@jaxxstorm
Copy link
Owner

sorry I think I was unclear, all I need is an example download in here: https://github.com/jaxxstorm/action-install-gh-release/blob/master/.github/workflows/test.yml

You've already got some examples in the readme, just add those to the workflow :)

@phillipjf
Copy link
Contributor Author

phillipjf commented May 6, 2022

@jaxxstorm thanks for the clarification. I pushed up an additional suite of jobs to test the changes I made. Looks like it needs approval to run.

edit: actually -- glossed over using the which command with windows... I wanted to test pulling multiple arch combinations but I don't think it will be feasible without custom runners as all the hosted runners will be amd64

@phillipjf
Copy link
Contributor Author

phillipjf commented May 6, 2022

@jaxxstorm I revised the test action. I'll review the results once it's approved to run. You can cancel the previous run.

@phillipjf
Copy link
Contributor Author

pushed a fix for the action..typo in the platform input.

@phillipjf
Copy link
Contributor Author

phillipjf commented May 6, 2022

I added info logging to aid in identifying situations where the user might need to identify what the action is searching. This gives the actual value reported by the runner along with what value is being used for searching (i.e. if it's being overridden by the arguments).

==> System reported platform: win32
==> Using platform: windows
==> System reported arch: x64
==> Using arch: amd64
searching for tfsec-checkgen-darwin-amd64 with (windows|amd64).*(windows|amd64).*.(tar.gz|zip)
...

Based on the last run, everything looks as expected.

@jaxxstorm
Copy link
Owner

Awesome! thanks for the amazing contribution

@jaxxstorm jaxxstorm merged commit 5ec0ddb into jaxxstorm:master May 6, 2022
@phillipjf phillipjf deleted the feature/flexible-release branch May 9, 2022 12:39
@phillipjf
Copy link
Contributor Author

@jaxxstorm when you have a chance, can you create a tag/release for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants