Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMO] Desite #145

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[DEMO] Desite #145

wants to merge 7 commits into from

Conversation

cstamas
Copy link

@cstamas cstamas commented Nov 16, 2022

"De-site", try to reproduce all the Jaxen site had without using maven-site-plugin.

Check DESITE.txt for progress.

In this PR, to build all (artifacts and site), you need only one Maven invocation:
mvn clean install -P site

Checpoint No1: lays down foundations, and renders page, but just basics, no CSS, no proper templates, no nothing yet, just a "welcome" page that contains all the content that CURRENT jaxen site has (generated ones, authored needs to be translated from XDoc to Markdown).

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems massively more complex than using the Maven site plugin. A lot of things the site plugin provides out of the box have to be manually written with this approach. That's good if you want to customize everything, but not so good if you just want to get a usable site for a project without excess effort.

@@ -13,7 +13,7 @@

<artifactId>jaxen</artifactId>
<packaging>bundle</packaging>
<name>jaxen</name>
<name>${project.artifactId}</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That these are the same is a coincidence. They are not semantically equivalent and shouldn't be linked with a variable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed, i was just lost about directory names, artifactIds and <name> names...

@cstamas
Copy link
Author

cstamas commented Nov 17, 2022

This seems massively more complex than using the Maven site plugin. A lot of things the site plugin provides out of the box have to be manually written with this approach. That's good if you want to customize everything, but not so good if you just want to get a usable site for a project without excess effort.

Unsure what you refer to "have to be manually written", as basically all that maven site provides here is "skin", nothing more, but that one could be just zipped up for jbake and reused, and using unpack-dependency pulled down and done.

@elharo
Copy link
Contributor

elharo commented Nov 17, 2022

By my count this adds eight non-empty files to make this work for things like sidebars that come for free with the maven site plugin. The existing jaxen site only includes custom jaxen specific content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants