fix: support prefixed names in patterns #115
Conversation
re-add PatternParserTest
There was a problem hiding this comment.
The pattern package is not very well documented, designed, or supported. If not for backwards compatibility, I would have deleted it long ago. I'll look at this, but it's unlikely this is the only change you'll need here. You might be better served by forking this. I'm not sure the existing design, API, and codebase is fixable or maintainable.
|
Are there plans to replace the |
|
There are no such plans. I was planning on deleting it eventually. It has no tests currently, and you're the first person I've ever heard from whose using it. |
| @@ -0,0 +1,77 @@ | |||
| /* | |||
| * | ||
| * ==================================================================== | ||
| * | ||
| * Copyright 2000-2002 bob mcwhirter & James Strachan. |
| * individuals on behalf of the Jaxen Project and was originally | ||
| * created by bob mcwhirter <bob@werken.com> and | ||
| * James Strachan <jstrachan@apache.org>. For more information on the | ||
| * Jaxen Project, please see <http://www.jaxen.org/>. |
There was a problem hiding this comment.
| * James Strachan <jstrachan@apache.org>. For more information on the | ||
| * Jaxen Project, please see <http://www.jaxen.org/>. | ||
| * | ||
| * $Id$ |
| * | ||
| * @author Claude Mamo | ||
| */ | ||
| public class NameNamespaceCompositeTest extends NodeTest |
There was a problem hiding this comment.
QualifiedNameTest or perhaps PrefixedNameTest
|
|
||
| public String getText() | ||
| { | ||
| return namespaceTest.getText() + nameTest.getText(); |
There was a problem hiding this comment.
should there be a separator here?
@OverRide
| path.setNodeTest( new NameTest( localName, nodeType ) ); | ||
| // XXXX: should support namespace in the test too | ||
| NameTest nameTest = new NameTest( localName, nodeType ); | ||
| NodeTest nodeTest; |
There was a problem hiding this comment.
I think it might be a little clearer if you pushed this into the if-block and called setNodeTest from within each branch.
| * | ||
| * ==================================================================== | ||
| * | ||
| * Copyright 2000-2002 bob mcwhirter & James Strachan. |
| "+" | ||
| }; | ||
|
|
||
| public PatternParserTest(String name) |
| XPathFunctionContext.getInstance(), | ||
| new SimpleVariableContext(), | ||
| new DocumentNavigator()); | ||
| assertTrue(pattern.matches(DocumentBuilderFactory.newInstance().newDocumentBuilder().newDocument(). |
There was a problem hiding this comment.
break this statement up with some local variables for clarity
re-add PatternParserTest