Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lexical Preserving Fails To Remove Comment #3810

Merged
merged 6 commits into from Dec 19, 2022

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Dec 19, 2022

Fixes #3796 .

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #3810 (966e091) into master (e72e340) will decrease coverage by 0.013%.
The diff coverage is 76.470%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3810       +/-   ##
===============================================
- Coverage     57.574%   57.560%   -0.014%     
  Complexity      2182      2182               
===============================================
  Files            638       638               
  Lines          33878     33907       +29     
  Branches        5850      5863       +13     
===============================================
+ Hits           19505     19517       +12     
- Misses         12293     12308       +15     
- Partials        2080      2082        +2     
Flag Coverage Δ
AlsoSlowTests 57.560% <76.470%> (-0.014%) ⬇️
javaparser-core 50.324% <76.470%> (-0.010%) ⬇️
javaparser-symbol-solver 36.579% <0.000%> (-0.032%) ⬇️
jdk-10 57.556% <76.470%> (-0.008%) ⬇️
jdk-11 57.550% <76.470%> (-0.020%) ⬇️
jdk-12 57.556% <76.470%> (-0.008%) ⬇️
jdk-13 57.556% <76.470%> (-0.008%) ⬇️
jdk-14 57.550% <76.470%> (-0.020%) ⬇️
jdk-15 57.556% <76.470%> (-0.014%) ⬇️
jdk-16 57.553% <76.470%> (-0.017%) ⬇️
jdk-8 57.557% <76.470%> (-0.014%) ⬇️
jdk-9 57.556% <76.470%> (-0.014%) ⬇️
macos-latest 57.551% <76.470%> (-0.014%) ⬇️
ubuntu-latest 57.545% <76.470%> (-0.014%) ⬇️
windows-latest 57.542% <76.470%> (-0.014%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...parser/printer/lexicalpreservation/Difference.java 77.920% <73.333%> (-1.649%) ⬇️
...vaparser/printer/concretesyntaxmodel/CsmToken.java 72.727% <100.000%> (+2.959%) ⬆️
...avaparser/printer/lexicalpreservation/Removed.java 77.500% <100.000%> (+8.055%) ⬆️
...rser/printer/lexicalpreservation/RemovedGroup.java 75.000% <100.000%> (-9.508%) ⬇️
...xicalpreservation/LexicalDifferenceCalculator.java 75.124% <0.000%> (+0.497%) ⬆️
...github/javaparser/ast/visitor/HashCodeVisitor.java 14.150% <0.000%> (+0.943%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72e340...966e091. Read the comment docs.

@jlerbsc jlerbsc merged commit 02fc8fc into javaparser:master Dec 19, 2022
@jlerbsc jlerbsc added this to the Next release milestone Dec 19, 2022
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lexical Preserving Fails To Remove Comment
1 participant