New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic CheckStyle validation #3781
Basic CheckStyle validation #3781
Conversation
There are 2419 errors reported by Checkstyle 8.45.1 with dev-files/JavaParser-CheckStyle.xml ruleset. The approach is good but it is unmanageable. |
Hi @jlerbsc , thanks for your feedback. I totally agree with you when you say it's unmanageable. Breaking down the 2419 results we have the following cases:
One way of doing this, would be to changing the severity of "LineLength" from error (which means mandatory) to a warning. By doing this, it will not break the build but for developers will have a warning notifying about a improvement to be done, like shown below: About the topic Indentation and CustomImportOrder, this can be easily fixed with the IDE tools and if you want i can include that fix on another PR, or if you prefer on this one :) Do you think it can be manageable this way? |
It actually seems a lot more manageable to me. But above all, it must not block a PR for the moment. |
Updated the Checkstyle to report every violation as Warning. |
This PR pretends to help improving the quality of the code, by providing a code style validation while the feature is in development.
This is a simple CheckStyle based at Coding Guidelines.
What do you think of this feature? Would it help delivering value to the project?