New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "executable" bit from code files #3755
Remove "executable" bit from code files #3755
Conversation
They serve no purpose but I suspect seem to annoy a security lint.
The check failures look like flakes, but I don't have permissions to rerun them. |
Why do you want to push this change? What is the problem you are trying to solve? |
The errors seem to be related to codecov
|
IIUC our organisation has a security linter that requires extra review when pulling executable files (to make sure we don't fetch harmful scripts). So it requires this extra review for the safe java files as well, in case someone makes them a shell script. Not setting them as executable removes this attack vector.
Could you kick off a rerun of the failures? It looks like the coverage itself succeeded, just the upload failed due to some consistency issue? Thanks :) |
Codecov Report
@@ Coverage Diff @@
## master #3755 +/- ##
=============================================
Coverage 57.433% 57.433%
- Complexity 2680 5463 +2783
=============================================
Files 636 636
Lines 33613 33613
Branches 5791 5791
=============================================
Hits 19305 19305
Misses 12254 12254
Partials 2054 2054
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
They serve no purpose, but I suspect seem to annoy a security lint.
Some code files have 755 permissions, others didn't, probably random depending on which OS was used to submit.