Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "executable" bit from code files #3755

Conversation

icmdaf
Copy link
Contributor

@icmdaf icmdaf commented Nov 17, 2022

They serve no purpose, but I suspect seem to annoy a security lint.

Some code files have 755 permissions, others didn't, probably random depending on which OS was used to submit.

They serve no purpose but I suspect seem to annoy a security lint.
@icmdaf
Copy link
Contributor Author

icmdaf commented Nov 17, 2022

The check failures look like flakes, but I don't have permissions to rerun them.

@jlerbsc
Copy link
Collaborator

jlerbsc commented Nov 17, 2022

Why do you want to push this change? What is the problem you are trying to solve?

@jlerbsc
Copy link
Collaborator

jlerbsc commented Nov 17, 2022

The errors seem to be related to codecov

 [2022-11-17T17:17:57.875Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:] 
(https://codecov.io/) Error: There was an error fetching the storage URL during POST: [40](https://github.com/javaparser/javaparser/actions/runs/3490304574/jobs/5841563430#step:7:41)4 - {'detail': 
ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Error: Codecov: Failed to properly upload: The process '/Users/runner/work/_actions/codecov/codecov-action/v3.1.1/dist/codecov' failed with exit code 255

@icmdaf
Copy link
Contributor Author

icmdaf commented Nov 18, 2022

Why

IIUC our organisation has a security linter that requires extra review when pulling executable files (to make sure we don't fetch harmful scripts). So it requires this extra review for the safe java files as well, in case someone makes them a shell script. Not setting them as executable removes this attack vector.

The errors

Could you kick off a rerun of the failures? It looks like the coverage itself succeeded, just the upload failed due to some consistency issue?

Thanks :)

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #3755 (6dc6a64) into master (587849c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              master     #3755     +/-   ##
=============================================
  Coverage     57.433%   57.433%             
- Complexity      2680      5463   +2783     
=============================================
  Files            636       636             
  Lines          33613     33613             
  Branches        5791      5791             
=============================================
  Hits           19305     19305             
  Misses         12254     12254             
  Partials        2054      2054             
Flag Coverage Δ
AlsoSlowTests 57.433% <ø> (ø)
javaparser-core 52.617% <ø> (ø)
javaparser-symbol-solver 36.762% <ø> (ø)
jdk-10 57.428% <ø> (ø)
jdk-11 57.425% <ø> (ø)
jdk-12 57.422% <ø> (ø)
jdk-13 57.428% <ø> (ø)
jdk-14 57.428% <ø> (ø)
jdk-15 57.428% <ø> (ø)
jdk-16 57.428% <ø> (ø)
jdk-8 57.424% <ø> (-0.006%) ⬇️
jdk-9 57.422% <ø> (-0.006%) ⬇️
macos-latest 57.421% <ø> (ø)
ubuntu-latest 57.418% <ø> (ø)
windows-latest 57.412% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ithub/javaparser/printer/DefaultPrettyPrinter.java 100.000% <ø> (ø)
...avaparser/printer/DefaultPrettyPrinterVisitor.java 92.851% <ø> (ø)
...nter/configuration/DefaultConfigurationOption.java 81.481% <ø> (ø)
...ter/configuration/DefaultPrinterConfiguration.java 87.096% <ø> (ø)
.../javaparser/printer/configuration/Indentation.java 97.058% <ø> (ø)
...r/symbolsolver/javaparsermodel/FailureHandler.java 42.857% <ø> (ø)
...ution/promotion/BooleanConditionalExprHandler.java 71.428% <ø> (ø)
.../resolution/promotion/ConditionalExprResolver.java 75.000% <ø> (ø)
...ution/promotion/NumericConditionalExprHandler.java 64.814% <ø> (ø)
...ion/promotion/ReferenceConditionalExprHandler.java 100.000% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587849c...6dc6a64. Read the comment docs.

@jlerbsc jlerbsc merged commit 1829e8a into javaparser:master Nov 18, 2022
@jlerbsc jlerbsc added this to the next release milestone Nov 18, 2022
@jlerbsc jlerbsc added the PR: Security A PR that addresses a security concern label Nov 18, 2022
@icmdaf icmdaf deleted the codespace-icmdaf-improved-cod-wrq5x9pwvqp3grwq branch November 18, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Security A PR that addresses a security concern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants