Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: X11 window move, resize, raise and lower calls #1602

Merged
merged 1 commit into from Apr 27, 2024

Conversation

vinceh121
Copy link
Contributor

This PR adds the following X11 calls:

  • XMoveWindow
  • XResizeWindow
  • XMoveResizeWindow
  • XRaiseWindow
  • XLowerWindow

@matthiasblaesing
Copy link
Member

@vinceh121 the change looks good, but please check the author value of the commit. The email part looks sane, but the name parts is incomplete/wrong. It should hold your real name, not a code name. So please

  1. Update the author information and ensure that it is complete (see here: https://www.git-tower.com/learn/git/faq/change-author-name-email)
  2. Please add an entry to CHANGES.md under "Features"

The two changes should be squashed into a single commit and forced pushed into this PR. Thank you.

@vinceh121
Copy link
Contributor Author

While I do think it is rather odd to enforce full names, I don't mind it, so I amended the commit along with the changes in the changelog.

CHANGES.md Outdated Show resolved Hide resolved
@matthiasblaesing
Copy link
Member

Looks sane to me. The test failures on mac OS are caused by changes in the github base image and not relevant here. Will be fixed by 1b86791 when #1603 is merged.

A warning: github sends info to participating parties for many changes, but not for forced pushes. The final push after @dblock comment might have been gone unnoticed.

@matthiasblaesing matthiasblaesing merged commit 40f0a12 into java-native-access:master Apr 27, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants