Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipping temp. dir creation when removing temp. files #1598

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trespasserw
Copy link
Contributor

A temp. directory is not needed when an app doesn't unpack libraries from a classpath – e.g., sets jna.boot.library.path and only uses system libraries. Skipping directory creation decreases app startup time and reduces the chances of being locked by overzealous AV software.

@matthiasblaesing
Copy link
Member

While I see what you are doing here, wouldn't it be as easy to just set the system property jna.nounpack to true? That way you make the intention clear and prevent the JNA automatic mechanisms from kicking in. From my POV that is the more complete solution to the stated problem.

@trespasserw
Copy link
Contributor Author

(sorry for the noise, I keep forgetting this PR was created from the main branch)

That's correct, setting jna.nounpack would be more radical. But it might be too radical: I tried setting it once for IJ IDEA, and while the app itself was working just fine, it broke one of 3rd-party plugins. Though in this case a stricter behavior might be more important than compatibility 🤔

Please feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants