Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNA wrapper for BSD <sys/extattr.h> #1549

Closed
wants to merge 0 commits into from

Conversation

rednoah
Copy link
Contributor

@rednoah rednoah commented Aug 25, 2023

This is a JNA wrapper for the libc xattr functions on BSD platforms (similar to the native bindings already available for Linux and macOS in the platform jar).

The primary motivation for this contribution is UnixUserDefinedFileAttributeView.list() not working in the OpenJDK FreeBSD port:
battleblow/jdk17u@05dca17#r125181377

NOTE:

This code is tested on production on FreeBSD, but we don't have automated test cases because the sys/extattr.h native functions are only available on BSD platforms, and so automated tests on Linux won't work.

Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I left a few inline comments. Apart from these

@rednoah
Copy link
Contributor Author

rednoah commented Aug 31, 2023

I've made the suggested changes.

@matthiasblaesing
Copy link
Member

Thank you for the update. Would you please rebase onto master and squash this into a single commit? I'll merge then.

@rednoah
Copy link
Contributor Author

rednoah commented Sep 1, 2023

GitHub still doesn't have a "merge as single commit" button just for the convenience? I'll see what I can do.

@matthiasblaesing
Copy link
Member

It has, and literally everytime I used it, it broke something. github has a funny interpretation what is valid author information. The Apache NetBeans project deactivated the button as multiple time merges were done with STUPID_NICK_NAME <STUPID_NICK_NAME@users.noreply.github.com> as author. From my POV this is not acceptable and in stark contrast to the much more sane behavior of the command line git client.

If a local squash is a problem, please indicate, then I'll do it.

@rednoah
Copy link
Contributor Author

rednoah commented Sep 1, 2023

Well, that didn't work...

@rednoah
Copy link
Contributor Author

rednoah commented Sep 1, 2023

No worries. I'll just make a new clean PR.

@rednoah
Copy link
Contributor Author

rednoah commented Sep 1, 2023

Sorry, I was out-gitted and broke things.

New PR here:
#1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants