Loongarch: Add Loongarch port #1406
Conversation
This patch adds support for the LoongArch architecture Note: libffi code is copy from https://github.com/loongson/libffi
There was a problem hiding this comment.
Thank you and sorry for the late review. I would prefer if the loongarch changes could flow through libffi first. If the change is merged to upstream libffi, we can update to a current copy of libffi. Carrying custom patches for libffi in the JNA repository is a reality, but also problematic and should be kept to a minimum.
Is the upstream integration already done?
| OS_PLATFORM = $(shell uname -m) | ||
| ifeq ($(OS_PLATFORM), loongarch64) | ||
| LDFLAGS += -Wl,-z,noexecstack | ||
| endif |
There was a problem hiding this comment.
This look broken as for example android and at least windows aarch64 are crossbuild, so the local platform should not affect the build. Also the other architectures have no similar treatment and mips64 should not even be touched, as this is targetted for loongarch.
There was a problem hiding this comment.
This look broken as for example android and at least windows aarch64 are crossbuild, so the local platform should not affect the build. Also the other architectures have no similar treatment and mips64 should not even be touched, as this is targetted for loongarch.
My fault. I will revise it
Thanks for your reply. The change is is not merge to upstream yet, but I am trying to do it. |
|
FYI, JNA loongarch64 port is maintained at https://github.com/loongson/jna before the port is accepted by JNA upstream. |
|
LoongArch port has been merged to upstream libffi, libffi/libffi@f259a6f. |
Should we not re-open this issue then, and consider using the port to generate a PR? |
I think so. I want to open a new pr to continue my job. |
|
Just for the record: #1440 |
This patch adds support for the LoongArch architecture
Note: libffi code is copy from https://github.com/loongson/libffi