Add mapping for EnumProcesses to Psapi #1214

T-Svensson · 2020-06-26T19:47:11Z

No description provided.

Added arm64 support to .travis.yml file

Add structures and methods to enumerate sessions

Closes: java-native-access#1200

Remove too-strict filestore available size test

Add mappings for Thread32First and Thread32Next to Kernel32

dbwiddis

Thanks for your submission! I've left a few comments inline.

contrib/platform/src/com/sun/jna/platform/win32/Psapi.java

contrib/platform/test/com/sun/jna/platform/win32/PsapiTest.java

T-Svensson · 2020-06-28T10:32:03Z

Please review again @dbwiddis, I think I covered all your comments.

dbwiddis

Looking good. A few more comments.

contrib/platform/src/com/sun/jna/platform/win32/PsapiUtil.java

contrib/platform/test/com/sun/jna/platform/win32/PsapiTest.java

T-Svensson · 2020-06-28T19:19:41Z

Since there was no additional comment on my questions above, I've uploaded a new changeset that addresses the other topics.

dbwiddis · 2020-06-28T21:22:58Z

It looks generally good to me. I don't seem to have the powers (yet) to merge this so I'll let @matthiasblaesing take it from here, if he has any other changes.

T-Svensson · 2020-06-29T18:55:18Z

I decided to add 2 more functions to the utility to extract the name of the process.
Looking forward to your feedback!

dbwiddis

Thanks for your patience. A few more comments.

contrib/platform/test/com/sun/jna/platform/win32/PsapiUtilTest.java

contrib/platform/src/com/sun/jna/platform/win32/PsapiUtil.java

contrib/platform/test/com/sun/jna/platform/win32/PsapiTest.java

contrib/platform/src/com/sun/jna/platform/win32/PsapiUtil.java

contrib/platform/test/com/sun/jna/platform/win32/PsapiUtilTest.java

contrib/platform/src/com/sun/jna/platform/win32/Kernel32Util.java

T-Svensson · 2020-06-30T20:00:21Z

Unless there are any obvious errors in the last push, I'll consider this PR ready for merge.

dbwiddis

Just a few last changes.

dbwiddis · 2020-06-30T23:32:58Z

contrib/platform/test/com/sun/jna/platform/win32/PsapiUtilTest.java

+        int[] pids = PsapiUtil.enumProcesses();
+
+        assertNotNull("List should not be null", pids);
+        assertTrue("List should contain my pid", Arrays.stream(pids).anyMatch(pid -> pid == myPid));


We retain compatibility with Java 1.6, so as neat as streams and lambdas are, you have to do it the old fashioned way.

If you aim to also have the test classes in Java6, I suggest that the Eclipse project is set to have Java6 as the target and the build.xml should also check ./test-classes, not just ./classes.
Anyway, I'll push a fix for this.

There are one or two exceptions in the test classes that require Java 8, which is why the project includes a higher compatibility level in the config files, but we otherwise maintain the standard.

(I know this because I did the same thing not too long ago!)

dbwiddis · 2020-06-30T23:37:40Z

contrib/platform/src/com/sun/jna/platform/win32/Kernel32Util.java

+        int size = 0;
+        IntByReference lpdwSize = new IntByReference();
+        do {
+            size = size + 1024;


Since WinDef.MAX_PATH should work in most cases, let's use that as the initial size. You can initialize on line 914 and increment (I'm ok with += 1024) after the query conditional.

Added utility method QueryFullProcessImageName that takes a PID. Fixed QueryFullProcessImageName to properly handle paths longer than 260 characters that can happen on Win10 / paths with UNC.

dbwiddis · 2020-07-01T15:09:26Z

Thanks for the updates. I'll commit this later today.

dbwiddis · 2020-07-01T16:18:21Z

Merged in 22dc037

dbwiddis and others added 11 commits May 17, 2020 21:47

Add structures and methods to enumerate sessions

9c24002

Type mapping and enum fixes

cb2a1ba

Merge pull request java-native-access#1199 from odidev/jna_arm64

c585df7

Added arm64 support to .travis.yml file

Merge pull request java-native-access#1198 from dbwiddis/wts

1586e6f

Add structures and methods to enumerate sessions

Add mappings for Udev Library and ddd object oriented wrapper methods

72f8ea2

Merge branch 'pr-1200'

433821d

Closes: java-native-access#1200

Remove too-strict filestore available size test

17ba5a8

Merge pull request java-native-access#1203 from dbwiddis/fsavailfix

1e86b54

Remove too-strict filestore available size test

Add mappings for Thread32First and Thread32Next to Kernel32

9892e49

Merge pull request java-native-access#1209 from dbwiddis/thread32

43c4e67

Add mappings for Thread32First and Thread32Next to Kernel32

Add mappings for size_t, ssize_t, shared memory and libc file functions

d471b15

T-Svensson force-pushed the Psapi.EnumProcesses branch 2 times, most recently from eadcb25 to 9c27512 Compare June 26, 2020 20:04

dbwiddis reviewed Jun 26, 2020

View reviewed changes

T-Svensson force-pushed the Psapi.EnumProcesses branch from 9c27512 to 104889d Compare June 28, 2020 10:28

dbwiddis reviewed Jun 28, 2020

View reviewed changes

T-Svensson force-pushed the Psapi.EnumProcesses branch from 104889d to 3c0dc33 Compare June 28, 2020 19:18

T-Svensson force-pushed the Psapi.EnumProcesses branch 2 times, most recently from 758a829 to 8895113 Compare June 29, 2020 18:53

dbwiddis reviewed Jun 30, 2020

View reviewed changes

T-Svensson force-pushed the Psapi.EnumProcesses branch from 8895113 to 49c276a Compare June 30, 2020 08:03

T-Svensson commented Jun 30, 2020

View reviewed changes

contrib/platform/src/com/sun/jna/platform/win32/Kernel32Util.java Show resolved Hide resolved

T-Svensson force-pushed the Psapi.EnumProcesses branch from 49c276a to 3ccc9d1 Compare June 30, 2020 19:58

T-Svensson requested review from dbwiddis and matthiasblaesing June 30, 2020 20:03

dbwiddis reviewed Jun 30, 2020

View reviewed changes

Add mapping for EnumProcesses to Psapi

6579864

Added utility method QueryFullProcessImageName that takes a PID. Fixed QueryFullProcessImageName to properly handle paths longer than 260 characters that can happen on Win10 / paths with UNC.

T-Svensson force-pushed the Psapi.EnumProcesses branch from 3ccc9d1 to 6579864 Compare July 1, 2020 06:37

dbwiddis force-pushed the master branch from 8a44e4c to 22dc037 Compare July 1, 2020 16:16

dbwiddis closed this Jul 1, 2020

T-Svensson deleted the Psapi.EnumProcesses branch July 11, 2020 01:28

dbwiddis mentioned this pull request Dec 1, 2020

Fix unittests for windows 32bit intel #1278

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mapping for EnumProcesses to Psapi #1214

Add mapping for EnumProcesses to Psapi #1214

T-Svensson commented Jun 26, 2020

dbwiddis left a comment

T-Svensson commented Jun 28, 2020

dbwiddis left a comment

T-Svensson commented Jun 28, 2020

dbwiddis commented Jun 28, 2020

T-Svensson commented Jun 29, 2020

dbwiddis left a comment

T-Svensson commented Jun 30, 2020

dbwiddis left a comment

dbwiddis Jun 30, 2020

T-Svensson Jul 1, 2020

dbwiddis Jul 1, 2020

dbwiddis Jul 1, 2020

dbwiddis Jun 30, 2020

dbwiddis commented Jul 1, 2020

dbwiddis commented Jul 1, 2020

Add mapping for EnumProcesses to Psapi #1214

Add mapping for EnumProcesses to Psapi #1214

Conversation

T-Svensson commented Jun 26, 2020

dbwiddis left a comment

Choose a reason for hiding this comment

T-Svensson commented Jun 28, 2020

dbwiddis left a comment

Choose a reason for hiding this comment

T-Svensson commented Jun 28, 2020

dbwiddis commented Jun 28, 2020

T-Svensson commented Jun 29, 2020

dbwiddis left a comment

Choose a reason for hiding this comment

T-Svensson commented Jun 30, 2020

dbwiddis left a comment

Choose a reason for hiding this comment

dbwiddis Jun 30, 2020

Choose a reason for hiding this comment

T-Svensson Jul 1, 2020

Choose a reason for hiding this comment

dbwiddis Jul 1, 2020

Choose a reason for hiding this comment

dbwiddis Jul 1, 2020

Choose a reason for hiding this comment

dbwiddis Jun 30, 2020

Choose a reason for hiding this comment

dbwiddis commented Jul 1, 2020

dbwiddis commented Jul 1, 2020