Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kernel32#SetProcessAffinityMask #1168

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -9,6 +9,7 @@ Features
--------
* [#1160](https://github.com/java-native-access/jna/issues/1160): Make FileUtils#moveToTrash a varargs method - [@matthiasblaesing](https://github.com/matthiasblaesing).
* [#1167](https://github.com/java-native-access/jna/pull/1167): Add `c.s.j.p.win32.Kernel32.GetProcessAffinityMask` - [@dbwiddis](https://github.com/dbwiddis).
* [#1168](https://github.com/java-native-access/jna/pull/1168): Add `c.s.j.p.win32.Kernel32.SetProcessAffinityMask` - [@dbwiddis](https://github.com/dbwiddis).

Bug Fixes
---------
Expand Down
29 changes: 29 additions & 0 deletions contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java
Expand Up @@ -26,6 +26,8 @@
import com.sun.jna.LastErrorException;
import com.sun.jna.Native;
import com.sun.jna.Pointer;
import com.sun.jna.platform.win32.BaseTSD.ULONG_PTR;
import com.sun.jna.platform.win32.WinNT.HANDLE;
import com.sun.jna.ptr.IntByReference;
import com.sun.jna.ptr.PointerByReference;
import com.sun.jna.win32.StdCallLibrary;
Expand Down Expand Up @@ -335,6 +337,33 @@ boolean ReadFile(HANDLE hFile, byte[] lpBuffer, int nNumberOfBytesToRead,
boolean GetProcessAffinityMask(HANDLE hProcess, ULONG_PTRByReference lpProcessAffinityMask,
ULONG_PTRByReference lpSystemAffinityMask);

/**
* Sets a processor affinity mask for the threads of the specified process.
*
* @param hProcess
* A handle to the process whose affinity mask is to be set. This
* handle must have the {@link WinNT#PROCESS_SET_INFORMATION} access
* right.
* @param dwProcessAffinityMask
* The affinity mask for the threads of the process.
* <p>
* On a system with more than 64 processors, the affinity mask must
* specify processors in a single processor group.
* @return If the function succeeds, the return value is {@code true}.
* <p>
* If the function fails, the return value is {@code false}. To get
* extended error information, call {@link #GetLastError()}.
* <p>
* If the process affinity mask requests a processor that is not
* configured in the system, the last error code is
* {@link WinError#ERROR_INVALID_PARAMETER}.
* <p>
* On a system with more than 64 processors, if the calling process
* contains threads in more than one processor group, the last error
* code is {@link WinError#ERROR_INVALID_PARAMETER}.
*/
boolean SetProcessAffinityMask(HANDLE hProcess, ULONG_PTR dwProcessAffinityMask);

/**
* Retrieves the termination status of the specified process.
*
Expand Down
53 changes: 45 additions & 8 deletions contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java
Expand Up @@ -62,6 +62,7 @@
import com.sun.jna.Platform;
import com.sun.jna.Pointer;
import com.sun.jna.platform.win32.BaseTSD.SIZE_T;
import com.sun.jna.platform.win32.BaseTSD.ULONG_PTR;
import com.sun.jna.platform.win32.BaseTSD.ULONG_PTRByReference;
import com.sun.jna.platform.win32.Ntifs.REPARSE_DATA_BUFFER;
import com.sun.jna.platform.win32.Ntifs.SymbolicLinkReparseBuffer;
Expand Down Expand Up @@ -464,22 +465,58 @@ public void testGetProcessIoCounters() {
}
}

public void testGetProcessAffinityMask() {
int myPid = Kernel32.INSTANCE.GetCurrentProcessId();
HANDLE pHandle = Kernel32.INSTANCE.OpenProcess(WinNT.PROCESS_QUERY_INFORMATION, false, myPid);
public void testGetAndSetProcessAffinityMask() {
// Pseudo handle, no need to close. Has PROCESS_ALL_ACCESS right.
HANDLE pHandle = Kernel32.INSTANCE.GetCurrentProcess();
assertNotNull(pHandle);

ULONG_PTRByReference pProcessAffinity = new ULONG_PTRByReference();
ULONG_PTRByReference pSystemAffinity = new ULONG_PTRByReference();
assertTrue(Kernel32.INSTANCE.GetProcessAffinityMask(pHandle, pProcessAffinity, pSystemAffinity));
assertTrue("Failed to get affinity masks.",
Kernel32.INSTANCE.GetProcessAffinityMask(pHandle, pProcessAffinity, pSystemAffinity));

long processAffinity = pProcessAffinity.getValue().longValue();
long systemAffinity = pSystemAffinity.getValue().longValue();

assertEquals("Process affinity must be a subset of system affinity", processAffinity,
processAffinity & systemAffinity);
assertEquals("System affinity must be a superset of process affinity", systemAffinity,
processAffinity | systemAffinity);
if (systemAffinity == 0) {
// Rare case for process to be running in multiple processor groups, where both
// systemAffinity and processAffinity are 0 and we can't do anything else.
assertEquals(
"Both process and system affinity must be zero if this process is running in multiple processor groups",
processAffinity, systemAffinity);
} else {
// Test current affinity
assertEquals("Process affinity must be a subset of system affinity", processAffinity,
processAffinity & systemAffinity);
assertEquals("System affinity must be a superset of process affinity", systemAffinity,
processAffinity | systemAffinity);

// Set affinity to a single processor in the current system
long lowestOneBit = Long.lowestOneBit(systemAffinity);
ULONG_PTR dwProcessAffinityMask = new ULONG_PTR(lowestOneBit);
assertTrue("Failed to set affinity",
Kernel32.INSTANCE.SetProcessAffinityMask(pHandle, dwProcessAffinityMask));
assertTrue("Failed to get affinity masks.",
Kernel32.INSTANCE.GetProcessAffinityMask(pHandle, pProcessAffinity, pSystemAffinity));
assertEquals("Process affinity doesn't match what was just set", lowestOneBit,
pProcessAffinity.getValue().longValue());

// Now try to set affinity to an invalid processor
lowestOneBit = Long.lowestOneBit(~systemAffinity);
// In case we have exactly 64 processors we can't do this, otherwise...
if (lowestOneBit != 0) {
dwProcessAffinityMask = new ULONG_PTR(lowestOneBit);
assertFalse("Successfully set affinity when it should have failed",
Kernel32.INSTANCE.SetProcessAffinityMask(pHandle, dwProcessAffinityMask));
assertEquals("Last error should be ERROR_INVALID_PARAMETER", WinError.ERROR_INVALID_PARAMETER,
Kernel32.INSTANCE.GetLastError());
}

// Cleanup. Be nice and put affinity back where it started!
dwProcessAffinityMask = new ULONG_PTR(processAffinity);
assertTrue("Failed to restore affinity to original setting",
Kernel32.INSTANCE.SetProcessAffinityMask(pHandle, dwProcessAffinityMask));
}
}

public void testGetTempPath() {
Expand Down