Merge pull request #1398 from dbwiddis/maxtokensize

Increase Sspi#MAX_TOKEN_SIZE on Windows 8/Server 2012 and later
java-native-access · Nov 28, 2021 · 7dbbf4b · 7dbbf4b
2 parents ba80848 + de853f3
commit 7dbbf4b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -7,6 +7,7 @@ Next Release (5.11.0)
 
 Features
 --------
+* [#1398](https://github.com/java-native-access/jna/pull/1398): Increase `c.s.j.p.win32.Sspi#MAX_TOKEN_SIZE` on Windows 8/Server 2012 and later - [@dbwiddis](https://github.com/dbwiddis).
 
 Bug Fixes
 ---------

diff --git a/contrib/platform/src/com/sun/jna/platform/win32/Sspi.java b/contrib/platform/src/com/sun/jna/platform/win32/Sspi.java
@@ -37,9 +37,19 @@
 public interface Sspi {
 
     /**
-     * Maximum size in bytes of a security token.
+     * Maximum size in bytes of a security token. {@code MAX_TOKEN_SIZE} has the
+     * following default value, depending on the version of Windows that builds the
+     * token:
+     * <p>
+     * Windows Server 2008 R2 and earlier versions, and Windows 7 and earlier
+     * versions: 12,000 bytes. Windows Server 2012 and later versions, and Windows 8
+     * and later versions: 48,000 bytes
+     *
+     * @see <a href=
+     *      "https://docs.microsoft.com/en-us/troubleshoot/windows-server/windows-security/kerberos-authentication-problems-if-user-belongs-to-groups">Problems
+     *      with Kerberos authentication when a user belongs to many groups</a>
      */
-    int MAX_TOKEN_SIZE = 12288;
+    int MAX_TOKEN_SIZE = VersionHelpers.IsWindows8OrGreater() ? 48000 : 12000;
 
     // Flags for the fCredentialUse parameter of AcquireCredentialsHandle