Deep merge of https options (sindresorhus#1304)

jaulz · Jul 6, 2020 · cf89d30 · cf89d30
1 parent d73216b
commit cf89d30
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/source/core/index.ts b/source/core/index.ts
@@ -888,6 +888,10 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 		}
 
 		// HTTPS options
+		if (defaults?.https) {
+			options.https = {...defaults.https, ...options.https};
+		}
+
 		if ('rejectUnauthorized' in options) {
 			deprecationWarning('"options.rejectUnauthorized" is now deprecated, please use "options.https.rejectUnauthorized"');
 		}

diff --git a/test/merge-instances.ts b/test/merge-instances.ts
@@ -116,3 +116,33 @@ test('URL is not polluted', withServer, async (t, server, got) => {
 
 	t.is(normalizedOptions.username, '');
 });
+
+test('merging instances with HTTPS options', t => {
+	const instanceA = got.extend({https: {
+		rejectUnauthorized: true,
+		certificate: 'FIRST'
+	}});
+	const instanceB = got.extend({https: {
+		certificate: 'SECOND'
+	}});
+
+	const merged = instanceA.extend(instanceB);
+
+	t.true(merged.defaults.options.https?.rejectUnauthorized);
+	t.is(merged.defaults.options.https?.certificate, 'SECOND');
+});
+
+test('merging instances with HTTPS options undefined', t => {
+	const instanceA = got.extend({https: {
+		rejectUnauthorized: true,
+		certificate: 'FIRST'
+	}});
+	const instanceB = got.extend({https: {
+		certificate: undefined
+	}});
+
+	const merged = instanceA.extend(instanceB);
+
+	t.true(merged.defaults.options.https?.rejectUnauthorized);
+	t.is(merged.defaults.options.https?.certificate, undefined);
+});